Conversation
pcarruscag
approved these changes
Nov 10, 2022
pcarruscag
requested changes
Nov 10, 2022
Member
pcarruscag
left a comment
pcarruscag
left a comment
There was a problem hiding this comment.
Ok wait. @bigfooted also merged something to testcases with new restarts for the work in axisymmetry fix.
Contributor
Author
|
@pcarruscag @bigfooted It looks like some restart file and filenames changed. But I can hold off on fixing the regression value and merging the changes. |
pcarruscag
approved these changes
Nov 11, 2022
| with: | ||
| # -t <Tutorials-branch> -c <Testcases-branch> | ||
| args: -b ${{github.ref}} -t develop -c feature_cat_wall -s ${{matrix.testscript}} | ||
| args: -b ${{github.ref}} -t develop -c develop_tmp -s ${{matrix.testscript}} |
Member
There was a problem hiding this comment.
Update what you need to update but do not change this branch to develop for now
Contributor
Author
|
@pcarruscag I saw this got merged. What do you think the next steps are with develop_tmp? |
Member
|
We remove it after #1784 is merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
A recent change from #1417, which I merged in had the regression set to feature_cat_wall in the TestCases. This will update and fix that call. I'm sure I will need to check additional fixes associated with this change.